This repository was archived by the owner on Apr 4, 2025. It is now read-only.
Go local variants #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekMasher
commented
Dec 13, 2021
| abstract class Sources extends DataFlow::Node { } | ||
|
|
||
| // https://pkg.go.dev/os#Args | ||
| // class OsArgs extends Sources { |
Contributor
Author
There was a problem hiding this comment.
We need to support os.Args as this is the main use case
Contributor
Author
There was a problem hiding this comment.
@securingdev Can you help fix this issue?
Contributor
There was a problem hiding this comment.
Happy to take a crack at it @GeekMasher - can we connect at some point tomorrow so that I know what you're looking for (and why this section of code was in, and then commented out)?
Contributor
|
@GeekMasher I feel like I should have PR'd into this - we can probably close this one as duplicate now 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9